[quagga-dev 10360] Re: [PATCH] ospfd: restore nexthop IP for p2p interfaces

Joakim Tjernlund joakim.tjernlund at transmode.se
Wed Mar 20 20:39:44 GMT 2013


James Li <jli at cumulusnetworks.com> wrote on 2013/03/20 21:17:51:
> 
> On 3/20/13 1:03 PM, Joakim Tjernlund wrote:
> > James Li <jli at cumulusnetworks.com> wrote on 2013/03/20 20:38:56:
> >> I pasted the related section here (we are based off the 0.99.21). 
Will
> >> send out the full review soon. As can be seen, it's essentially the 
same
> >> thing. It's a good validation that we come to the same solution.
> > Great, I too have an unnumbered impl. but it is old now, the most
> > important stuff (SPF part)
> > is in Q now so I look forward to see the patches too. You can find all 
my
> > patches
> > in patchwork though.
> 
> I think the spf part is indeed the most crucial part. And yes, yours and 

> others' related patches were studied carefully.

Great, I will recognize some bits then :)

> >> diff --git a/ospfd/ospf_spf.c b/ospfd/ospf_spf.c
> >> index 8cd5512..135c086 100644
> > I don't think your patch supports multiple ptp links between the same 
two
> > routers?
> 
> should work fine. How might it break (even without the lsa_pos changes)?

Identifying the correct ptop I/F using IP address won't fly when you have 
the
same IP addresses on several ptop links.

 Jocke




More information about the Quagga-dev mailing list