[quagga-dev 10789] [PATCH] bgpd: Send notification in OpenSent state when bgp is stopped manually.

Vitaliy Senchyshyn vsenchyshyn at toroki.com
Tue Oct 1 18:59:05 BST 2013


Hi everyone,

Please take a look at the patch file attached.

The issue it fixes is that the notification message is not sent to a 
second peer when bgp is stopped manually.

According to BGP RFC4271, section 8.2.2, regarding the FSM transitions, 
in OpenSent state:

If a ManualStop event (Event 2) is issued in the OpenSent state, the 
local system:

  * sends the NOTIFICATION with a Cease,
  * sets the ConnectRetryTimer to zero,
  * releases all BGP resources,
  * drops the TCP connection,
  * sets the ConnectRetryCounter to zero, and
  * changes its state to Idle.

I've added a check for OpenSent state when the notification is sent from 
the functions which are called from the CLI commands which 
directly/indirectly stop/restart BGP.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.quagga.net/pipermail/quagga-dev/attachments/20131001/cbc1c31c/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: notification_in_open_sent.patch
Type: text/x-patch
Size: 8768 bytes
Desc: not available
URL: <http://lists.quagga.net/pipermail/quagga-dev/attachments/20131001/cbc1c31c/attachment-0001.bin>


More information about the Quagga-dev mailing list