[quagga-dev 10844] Re: [PATCH 2/4] zebra: quagga-re-onlink-support.patch

Joakim Tjernlund joakim.tjernlund at transmode.se
Thu Oct 24 16:29:27 BST 2013


Christian Franke <nobody at nowhere.ws> wrote on 2013/10/24 16:45:58:
> 
> On 10/24/2013 12:44 AM, Joakim Tjernlund wrote:
> > Dinesh G Dutt <ddutt at cumulusnetworks.com> wrote on 2013/10/24 
06:06:43:
> >> quagga-re-onlink-support.patch
> 
> > I recall this patch had some doubts in the past, I found my own 
comments 
> > in quagga-dev 9519
> 
> Have you had a look at quagga-dev 10576? I feel that this general
> approach might be a bit better as it doesn't yet introduce another
> nexthop type, but there hasn't been all that much feedback on comparing
> the two.

Had not seen that one but it does exactly what I meant, add onlink to 
existing
flags field.

> 
> Quagga master supports NEXTHOP_IPV4_IFINDEX properly, so the only thing
> that still has to be done on top of this patch would be adding a way
> that allows routing daemons to set the NEXTHOP_FLAG_ONLINK via the IPC
> protocol. (I only required that flag internally in zebra to address the
> case of some recursive routes. Therefore, the patch didn't add a way to
> set that flag via IPC, that shouldn't be too complicated though.)

Yes, now one can add the remaining daemons easily.
Nice :)

 Jocke 




More information about the Quagga-dev mailing list