[quagga-dev 10852] Re: [PATCH 3/4] ospfd: ospfd-unnumbered-interface-support.patch

James Li jli at cumulusnetworks.com
Thu Oct 24 22:31:48 BST 2013


Hi Jocke, I will send some design notes via another thread, and leave 
this one for code review.

thanks,
James

On 10/24/13 12:40 AM, Joakim Tjernlund wrote:
> Dinesh G Dutt <ddutt at cumulusnetworks.com> wrote on 2013/10/24 06:06:50:
>
>> From: Dinesh G Dutt <ddutt at cumulusnetworks.com>
>> To: quagga-dev at lists.quagga.net,
>> Cc: shm at cumulusnetworks.com, jli at cumulusnetworks.com,
> ayabaner at gmail.com, sfeldma at cumulusnetworks.com
>> Date: 2013/10/24 06:13
>> Subject: [quagga-dev 10830] [PATCH 3/4] ospfd:
> ospfd-unnumbered-interface-support.patch
>> OSPFv2: Support for Unnumbered interface.
>>
>> Unnumbered interface support for OSPFv2.
>>
>> Signed-off-by: James Li <jli at cumulusnetworks.com>
>> Reviewed-by: Dinesh Dutt <ddutt at cumulusnetworks.com>
>> ---
>>   lib/if.c               |   29 +++++++++++++++++++++++++
>>   lib/if.h               |   10 ++++++++-
>>   lib/zebra.h            |    1 +
>>   ospfd/ospf_interface.c |   13 +++++++++--
>>   ospfd/ospf_lsa.c       |   39 ++++++++++++++++++++++++----------
>>   ospfd/ospf_route.c     |    4 +++
>>   ospfd/ospf_route.h     |    1 +
>>   ospfd/ospf_vty.c       |   55
> +++++++++++++++++++++++++++---------------------
>>   ospfd/ospf_zebra.c     |   45 +++++++++++++++++++++++++++++++++++++++
>>   zebra/connected.c      |   51
> ++++++++++++++++++++++++++++++++++++++++++++-
>>   zebra/connected.h      |    3 +++
>>   zebra/interface.c      |   18 ++++++++++++++++
>>   12 files changed, 228 insertions(+), 41 deletions(-)
> This is just one big patch touching lots of files and the only clue you
> have is
> "Unnumbered interface support for OSPFv2."
> Makes it very hard to understand the logic behind the different changes, I
> cannot
> make out the different parts.
>
>   Jocke





More information about the Quagga-dev mailing list