[quagga-dev 10856] Re: [PATCH 3/4] ospfd: ospfd-unnumbered-interface-support.patch

Joakim Tjernlund joakim.tjernlund at transmode.se
Fri Oct 25 08:27:02 BST 2013


James Li <jli at cumulusnetworks.com> wrote on 2013/10/25 01:08:01:

> From: James Li <jli at cumulusnetworks.com>
> To: Joakim Tjernlund <joakim.tjernlund at transmode.se>, 
> Cc: ayabaner at gmail.com, Dinesh G Dutt <ddutt at cumulusnetworks.com>, 
quagga-dev at lists.quagga.net, sfeldma at cumulusnetworks.com, 
shm at cumulusnetworks.com
> Date: 2013/10/25 01:08
> Subject: Re: [quagga-dev 10830] [PATCH 3/4] ospfd: 
ospfd-unnumbered-interface-support.patch
> 
> On 10/24/13 3:46 PM, Joakim Tjernlund wrote:
> > James Li <jli at cumulusnetworks.com> wrote on 2013/10/24 23:31:48:
> >> Hi Jocke, I will send some design notes via another thread, and leave
> >> this one for code review.
> > Sorry but I will not review this big all in one patch, design notes or
> > not.
> > The little I saw reminded me of my patches I sent years ago(still in
> > patchwork).
> > You might want to take a look at these.
> >
> 
> This patch is centered around unnumbered interface support, and every 
> line of change is an integral part of it. What can be pulled as separate 

> patch has been, i.e. the ONLINK and new CLI command "ip ospf area ..." 
> are 2 separate patches.

No, you can and should break it down into smaller logical pieces which
introduces the functionality stepwise. No patch can break the build 
either.

> 
> I don't know what's the history about your patch. Is it accepted and 
> merged into master? If not, and if it's a few years old, then my 
> understanding is it has expired. List masters please correct me if this 
> (w.r.t expiration) is not the right understanding.

I have lots of patches in patchwork, several are still relevant.
Especially those that fix some bug. They may not apply anymore but the
problem is still there.
For a long time I tried really hard to get them applied but as Q was 
unmaintained they got dropped on the floor. Now I just point out that
they are there for anyone who cares to look. Patchwork is basically a 
goldmine 
with stuff but you need to go through it carefully and ask questions.

> 
> thanks,
> James
> 
> >> thanks,
> >> James
> >>
> >> On 10/24/13 12:40 AM, Joakim Tjernlund wrote:
> >>> Dinesh G Dutt <ddutt at cumulusnetworks.com> wrote on 2013/10/24
> > 06:06:50:
> >>>> From: Dinesh G Dutt <ddutt at cumulusnetworks.com>
> >>>> To: quagga-dev at lists.quagga.net,
> >>>> Cc: shm at cumulusnetworks.com, jli at cumulusnetworks.com,
> >>> ayabaner at gmail.com, sfeldma at cumulusnetworks.com
> >>>> Date: 2013/10/24 06:13
> >>>> Subject: [quagga-dev 10830] [PATCH 3/4] ospfd:
> >>> ospfd-unnumbered-interface-support.patch
> >>>> OSPFv2: Support for Unnumbered interface.
> >>>>
> >>>> Unnumbered interface support for OSPFv2.
> >>>>
> >>>> Signed-off-by: James Li <jli at cumulusnetworks.com>
> >>>> Reviewed-by: Dinesh Dutt <ddutt at cumulusnetworks.com>
> >>>> ---
> >>>>    lib/if.c               |   29 +++++++++++++++++++++++++
> >>>>    lib/if.h               |   10 ++++++++-
> >>>>    lib/zebra.h            |    1 +
> >>>>    ospfd/ospf_interface.c |   13 +++++++++--
> >>>>    ospfd/ospf_lsa.c       |   39 ++++++++++++++++++++++++----------
> >>>>    ospfd/ospf_route.c     |    4 +++
> >>>>    ospfd/ospf_route.h     |    1 +
> >>>>    ospfd/ospf_vty.c       |   55
> >>> +++++++++++++++++++++++++++---------------------
> >>>>    ospfd/ospf_zebra.c     |   45
> > +++++++++++++++++++++++++++++++++++++++
> >>>>    zebra/connected.c      |   51
> >>> ++++++++++++++++++++++++++++++++++++++++++++-
> >>>>    zebra/connected.h      |    3 +++
> >>>>    zebra/interface.c      |   18 ++++++++++++++++
> >>>>    12 files changed, 228 insertions(+), 41 deletions(-)
> >>> This is just one big patch touching lots of files and the only clue
> > you
> >>> have is
> >>> "Unnumbered interface support for OSPFv2."
> >>> Makes it very hard to understand the logic behind the different
> > changes, I
> >>> cannot
> >>> make out the different parts.
> >>>
> >>>    Jocke
> 





More information about the Quagga-dev mailing list