[quagga-dev 11199] Re: [PATCH]ospfd: External Prefix Summarization

Joachim Nilsson troglobit at gmail.com
Thu Apr 24 06:31:07 BST 2014


On 2014-04-23 16:15, Christian Franke wrote:
> On 04/23/2014 12:01 PM, Troglobit wrote:
>> there hasn't been much input from the list on this feature, from others
>> than me, Greg and Jan of course.  So, due to increased interest in this
>> from customers I've started a refactoring and simplification of this
>> very neat ASBR feature.
>>
>> I'm focusing on reducing code duplication, aligning with established
>> name spaces, reusing existing frameworks as well as coding style and
>> documentation.  Still a n00b on the Quagga internals there are quite
>> a few things that would need auditing to get it done right(TM)
>>
>> It's a work in progress, but any input that would help get this feature
>> whipped into shape for the next Quagga merge window is very welcome.
>>
>>    https://github.com/troglobit/quagga/commits/ospfd/summary-address
> It's a funny coincidence that we both happend to take a poke at this
> almost at the same time.

:)

> I have done a review of the code as it was submitted by Jan. From what I
> see at the github page, you had already fixed some of things I pointed out.

Thank you for taking the time to do this, I hope you don't feel like 
you've wasted your time! I should have done this quite a while ago ...

Like I mentioned above, I've only focused on the more obvious things to 
start with and get a feel for the code.

> There are however still some things in my review which should probably
> be addressed, so it might be helpful to look at it nevertheless.

Yes, I'll have look at it later this week I hope and reply to the 
remaining issues, unless Jan beats me to it :)

Regards
  /Joachim





More information about the Quagga-dev mailing list