[quagga-dev 11346] [PATCH 1/6] ripd: use only one constant for derivation

Feng Lu lu.feng at 6wind.com
Wed Jun 25 09:43:15 BST 2014


RIP_MAX_RTE is defined in ripd.h as 25 but is in fact the
result of a formula. More over it is not used in the code:
the code itself includes the fomula. This makes it un-clear
for maintenance.

Signed-off-by: Feng Lu <lu.feng at 6wind.com>
Reviewed-by: Alain Ritoux <alain.ritoux at 6wind.com>
---
 ripd/ripd.c |    2 +-
 ripd/ripd.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ripd/ripd.c b/ripd/ripd.c
index dfeb951..8a7fef8 100644
--- a/ripd/ripd.c
+++ b/ripd/ripd.c
@@ -2169,7 +2169,7 @@ rip_output_process (struct connected *ifc, struct sockaddr_in *to,
 
   /* Reset stream and RTE counter. */
   stream_reset (s);
-  rtemax = (RIP_PACKET_MAXSIZ - 4) / 20;
+  rtemax = RIP_MAX_RTE;
 
   /* Get RIP interface. */
   ri = ifc->ifp->info;
diff --git a/ripd/ripd.h b/ripd/ripd.h
index 45b07b9..0fc2fd3 100644
--- a/ripd/ripd.h
+++ b/ripd/ripd.h
@@ -49,7 +49,7 @@
 #define RIP_RTE_SIZE                    20
 
 /* Max count of routing table entry in one rip packet. */
-#define RIP_MAX_RTE                     25
+#define RIP_MAX_RTE   ((RIP_PACKET_MAXSIZ - RIP_HEADER_SIZE) / RIP_RTE_SIZE)
 
 /* RIP version 2 multicast address. */
 #ifndef INADDR_RIP_GROUP
-- 
1.7.4.4





More information about the Quagga-dev mailing list