[quagga-dev 11256] Re: [PATCHv2] ospfd: PointToPoint neighbors are identified by router ID

Feng Lu lu.feng at 6wind.com
Mon May 5 08:39:02 BST 2014


It seems the fix still not completed.

Let's imagine what will happen if we change the network type of an
broadcast interface to point-to-point? The interface will be shut
down and then set up. The "nbr_self" is deleted and then recreated.
But the old "nbr_self" pointer can not be removed from the table
because the interface type has been changed (causing the neighbor
key changed). This pointer is a landmine.

So I think there would be more fixes needed for this issue. As far
as I know, we need also:

a) for the command "ip ospf network xxx", we should shut down the
    interface BEFORE changing its network type;
b) call ospf_nbr_add_self() only when the interface leaves the
    Down state.

Would anybody can help us with more idea about this issue?

Thanks and best regards,
Feng Lu

On 04/25/2014 08:36 PM, Joakim Tjernlund wrote:
> According to RFC 2328, section 10.5  PointToPoint neighbors
> should be identified by router ID instead of source IP address.
>
> Signed-off-by: Joakim Tjernlund<Joakim.Tjernlund at transmode.se>
> ---
>
>   v2 - Added ospf_nbr_key() and ospf_nbr_get per Feng Lu's request.
>        This is NOT tested as I don't have equipment handy.





More information about the Quagga-dev mailing list