[quagga-dev 11273] Re: [PATCHv2] ospfd: For an ABR, ensure the right LSID is MaxAge'd

David Lamparter equinox at opensourcerouting.org
Wed May 14 16:23:53 BST 2014


On Mon, Apr 28, 2014 at 01:58:06PM +0200, Christian Franke wrote:
> From: Pradosh Mohapatra <pmohapat at cumulusnetworks.com>
> 
> PROBLEM:
> 
> Accurate garbage collection of maxage LSAs. The global OSPF structure has
> a maxage_lsa tree - the key to the tree is <ls-id, adv-router> tuple. Suppose
> the ABR has multiple areas and has originated some intra-area LSAs. The
> key for all those LSAs is the same. The code then ends up in a state where
> all but the first LSA do not get cleaned up from the areas' LSDB. A subsequent
> event would readvertise those LSAs.
> 
> PATCH:
> 
> Since the LSA is going to stick around till it actually gets cleaned up by
> the maxage_walker, make the LSA pointer as the key. Each distinct LSA that
> gets maxage'd then gets added to the tree and will get cleaned up correctly.
> 
> Signed-off-by: Pradosh Mohapatra <pmohapat at cumulusnetworks.com>
> Signed-off-by: Christian Franke <chris at opensourcerouting.org>

Accepted - as temporary band-aid for 0.99.23.

This needs to be redone without putting pointers in route_tables.




More information about the Quagga-dev mailing list