[quagga-dev 11298] Re: [PATCH] bgpd: bgp_rr_next_hop_self.patch
timo.teras at iki.fi
Tue May 20 09:31:46 BST 2014
On Mon, 19 May 2014 23:59:43 +0200
David Lamparter <david at opensourcerouting.org> wrote:
> Timo's patch is nicer, for the following reasons:
> - it uses the new keyword syntax
> - it is shorter (as a result of the above)
> - the syntax is the same as on cisco
> - the force flag is additive in his patch, which I personally think is
> better than having the flag alternative
> - the patches are functionally identical otherwise
> The downside is, Timo's patch was submitted outside the merge
> window... which gets me to the above "sigh" - I'll pick up Timo's
> version, for 0.99.24.
> Sorry for the additional delay,
No problem. I understand that there's lots of stuff and releases need
to keep rolling.
> P.S.: Neither of you added documentation for the new flag
> ... gotta stop bending the (admittedly self-set) rules *somewhere*...
> been making far too many fixups already.
I can do this. In fact, I already added something, but can add more if
I also have other stuff brewing up. So I put my current git tree now to:
David, I can resend the patches, or prepare a branch that you can pull.
Let me just know which patches you want.
Especially, I would be interested to hear feedback on the idea of:
that is, to allow modifying metric with measured round trip time of
More information about the Quagga-dev