[quagga-dev 11590] Re: [PATCH 1/1] bgpd: implement route-map set as-path prepend last-as

Timo Teras timo.teras at iki.fi
Mon Oct 20 18:15:04 BST 2014


On Mon, 20 Oct 2014 17:53:06 +0100 (BST)
Paul Jakma <paul at jakma.org> wrote:

> On Tue, 7 Oct 2014, Timo Teras wrote:
> 
> > I'm fine either way. This was just the easy way out when writing the
> > patch.
> 
> Any opinions/objections on if I tweak your last-as patch with the 
> attached? (And could you sanity-check it, or even help test? :) ).
> 
> Also attached, 1 line docs for 'set as-path prepend ...'.

Doing it like this was in my mind at the beginning. I believe the only
thing that goes different is that now you can have separate 'set
as-path prepend' and 'set as-path prepend last-as' lines in the config.

Perhaps we could add bgp_route_set_delete() calls for the other type
to ensure that only one of them exists at a given time?

Otherwise, I think it should be good (after a quick glance).

/Timo 




More information about the Quagga-dev mailing list