[quagga-dev 12126] Re: running-config pollution by "router ospf"

serj.kalichev at gmail.com serj.kalichev at gmail.com
Thu Apr 2 19:42:22 BST 2015


Hi Vipin

Thanks for the answer.
The flag will be good.
But what do you think about the following behaviour (It seems I have 
read this idea in your log for the 4bab68 commit):
Use ospf_get() instead ospf_lookup() while processing the OSPF interface 
mode commands. So the ospf structure will be created on the event when 
the OSPF is really used.

02.04.2015 20:50, Vipin Kumar пишет:
> Hi Serj,
>
> Initially, I didn't think seeing 'router ospf' config by default when 
> ospfd is actually running will not be an issue to the user.
>
> However, to handle the OSPF interface mode commands properly and also 
> not change existing 'show running' output when there was no OSPF 
> config present, I added a flag to remember the configured state. This 
> new state/flag is then used to allow  OSPF visible/show operations. 
> Its a simple enough change.
>
> We have that patch also on the way to quagga-dev. Let me know if you 
> are interested in that.
>
> Thanks
> Vipin
>
> On Thu, Apr 2, 2015 at 8:28 AM, Serj Kalichev <serj.kalichev at gmail.com 
> <mailto:serj.kalichev at gmail.com>> wrote:
>
>     Hello
>
>     I use quagga-0.99.24.1 and have running-config pollution.
>     I start zebra daemon and then start ospfd daemon with the empty
>     config. I haven't enter any commands related to "router ospf" but
>     there is "router ospf" entry in running-config already.
>
>     The problem is with the commit
>     4bab6806914dbb4b43f376ebf966a034a0ea72cd
>     It uses ospf_get() on ospf daemon start. Without any conditions.
>     The ospf_get() creates new ospf structure.
>           ospf = ospf_new ();
>           ospf_add (ospf);
>
>     When I enter "show running-config" in vtysh it uses
>     ospf_config_write() to show ospf settings.
>       ospf = ospf_lookup ();
>       if (ospf != NULL)
>         {
>           /* `router ospf' print. */
>           vty_out (vty, "router ospf%s", VTY_NEWLINE);
>
>     The ospf_lookup() is already returns non-NULL value so it always
>     prints "router ospf" string.
>
>     Is there another way to satisfy interface mode commands without
>     running-config pollution?
>     Thanks
>
>
>
>
>
>     _______________________________________________
>     Quagga-dev mailing list
>     Quagga-dev at lists.quagga.net <mailto:Quagga-dev at lists.quagga.net>
>     https://lists.quagga.net/mailman/listinfo/quagga-dev
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.quagga.net/pipermail/quagga-dev/attachments/20150402/f71f8463/attachment-0001.html>


More information about the Quagga-dev mailing list