[quagga-dev 12141] Re: [PATCH 4/4] bgpd: Display of configured dampening parameters

David Lamparter equinox at opensourcerouting.org
Tue Apr 14 11:25:43 BST 2015


On Mon, Mar 16, 2015 at 11:25:29PM +0530, Balaji.G wrote:
> Function to display configured bgp dampening parameters.

Accepted (with format/string changes), Thanks!

> +      vty_out (vty, "Half-Life time : %ld mins %s",damp->half_life/60,VTY_NEWLINE);
> +      vty_out (vty, "Reuse Penalty : %d%s", damp->reuse_limit,VTY_NEWLINE);
> +      vty_out (vty, "Suppress penalty: %d%s",damp->suppress_value,VTY_NEWLINE);
> +      vty_out (vty, "Max suppress time: %ld mins %s",damp->max_suppress_time/60,VTY_NEWLINE);
> +      vty_out (vty, "Max Supress Penalty: %u%s",damp->ceiling, VTY_NEWLINE); 
> +      vty_out (vty, "%s", VTY_NEWLINE);

Adjusted some of the strings here to be consistent. (Penalty<>penalty,
mins->min, " %s" -> "%s" at end of line)

> +    }
> +    else
> +      vty_out (vty, "dampening not enabled for %s%s",
> +                   afi == AFI_IP ? "IPv4" : "IPv6", VTY_NEWLINE);

Block was mis-indented.
    }
    else
=>
    }
  else


-David




More information about the Quagga-dev mailing list