[quagga-dev 12154] Re: [PATCH 2/4] lib: straighten out ORF prefix list support

David Lamparter equinox at opensourcerouting.org
Sun Apr 19 00:33:41 BST 2015


On Fri, Apr 17, 2015 at 06:11:27PM +0100, Paul Jakma wrote:
> So, before there was just one ORF plist for any AFI?

One ORF plist master, having plists of different AFs (they had unique
names, so no collisions)

> By splitting it so there's per-AFI orfs, are there any configuration 
> breakage issues?

ORF plist usage is entirely ephemeral / has no connection to
configuration.  Normal configured prefix lists are untouched in
behaviour.


-David

> On Mon, 13 Apr 2015, David Lamparter wrote:
> > BGP ORF prefix lists are in a separate namespace; this was previously
> > hooked up with a special-purpose AFI value.  This is a little kludgy for
> > extension, hence this splits it off.
> >
> > Signed-off-by: David Lamparter <equinox at opensourcerouting.org>
> > ---
> > bgpd/bgp_fsm.c    |   2 +-
> > bgpd/bgp_packet.c |   6 +--
> > bgpd/bgpd.c       |   2 +-
> > lib/plist.c       | 149 +++++++++++++++++++-----------------------------------
> > lib/plist.h       |   5 +-
> > 5 files changed, 58 insertions(+), 106 deletions(-)
> >
> > diff --git a/bgpd/bgp_fsm.c b/bgpd/bgp_fsm.c
> > index 112c34a..d261bb5 100644
> > --- a/bgpd/bgp_fsm.c
> > +++ b/bgpd/bgp_fsm.c
> > @@ -545,7 +545,7 @@ bgp_stop (struct peer *peer)
> 
> regards,
> -- 
> Paul Jakma	paul at jakma.org	@pjakma	Key ID: 64A2FF6A
> Fortune:
> Learned men are the cisterns of knowledge, not the fountainheads.
> 
> _______________________________________________
> Quagga-dev mailing list
> Quagga-dev at lists.quagga.net
> https://lists.quagga.net/mailman/listinfo/quagga-dev




More information about the Quagga-dev mailing list