[quagga-dev 12160] Re: [GIT RFC] "final" warning cleanup
equinox at opensourcerouting.org
Sun Apr 19 19:53:48 BST 2015
On Wed, Mar 04, 2015 at 08:23:02AM -0500, Donald Sharp wrote:
> can we set token = ecommunity_token_unknown instead of 0? I wouldn't mind
> moving ecommunity_token_unknown to the front of the enum either.
> Why not just remove the lines, instead of commenting them out, and why set
> some variables to unused? Just remove them as well?
The lines that I didn't remove either will become useful at some future
point (isis_zebra), serve as documentation (isis_tlv), or may need
additional checking beyond removing compiler warnings (isis_lsp).
Thanks for the feedback,
More information about the Quagga-dev