[quagga-dev 12160] Re: [GIT RFC] "final" warning cleanup

David Lamparter equinox at opensourcerouting.org
Sun Apr 19 19:53:48 BST 2015


On Wed, Mar 04, 2015 at 08:23:02AM -0500, Donald Sharp wrote:
> can we set token = ecommunity_token_unknown instead of 0?  I wouldn't mind
> moving ecommunity_token_unknown to the front of the enum either.

done

> http://git.savannah.gnu.org/cgit/quagga.git/commit/?h=volatile/fix_warnings&id=fc671a1d779ce65740689af7522e5b68e00a451e
> 
> Why not just remove the lines, instead of commenting them out, and why set
> some variables to unused?  Just remove them as well?

The lines that I didn't remove either will become useful at some future
point (isis_zebra), serve as documentation (isis_tlv), or may need
additional checking beyond removing compiler warnings (isis_lsp).

Thanks for the feedback,


-David




More information about the Quagga-dev mailing list