[quagga-dev 11997] [PATCH 14/15] zebra: mark multicast commands experimental

David Lamparter equinox at opensourcerouting.org
Fri Jan 30 00:54:32 GMT 2015


depending on feedback from actually having these commands in a released
version, we may want to adjust them.  Thus, mark them as experimental so
users are aware of this.

Cc: Everton Marques <everton.marques at gmail.com>
Cc: Balaji G <balajig81 at gmail.com>
Signed-off-by: David Lamparter <equinox at opensourcerouting.org>
---
 lib/vty.h         | 8 ++++++++
 zebra/zebra_vty.c | 7 +++++++
 2 files changed, 15 insertions(+)

diff --git a/lib/vty.h b/lib/vty.h
index 4d6048c..f31f4b5 100644
--- a/lib/vty.h
+++ b/lib/vty.h
@@ -217,6 +217,14 @@ do {
     }                                                                         \
 } while (0)
 
+#define VTY_WARN_EXPERIMENTAL()                                               \
+do {                                                                          \
+  vty_out (vty, "%% WARNING: this command is experimental. Both its name and" \
+                " parameters may%s%% change in a future version of Quagga,"   \
+                " possibly breaking your configuration!%s",                   \
+                VTY_NEWLINE, VTY_NEWLINE);                                    \
+} while (0)
+
 /* Exported variables */
 extern char integrate_default[];
 
diff --git a/zebra/zebra_vty.c b/zebra/zebra_vty.c
index 29c01c3..598b40d 100644
--- a/zebra/zebra_vty.c
+++ b/zebra/zebra_vty.c
@@ -154,6 +154,7 @@ DEFUN (ip_mroute_dist,
        "Nexthop interface name\n"
        "Distance\n")
 {
+  VTY_WARN_EXPERIMENTAL();
   return zebra_static_ipv4_safi(vty, SAFI_MULTICAST, 1, argv[0], NULL, argv[1],
                                 NULL, argc > 2 ? argv[2] : NULL);
 }
@@ -177,6 +178,7 @@ DEFUN (no_ip_mroute_dist,
        "Nexthop interface name\n"
        "Distance\n")
 {
+  VTY_WARN_EXPERIMENTAL();
   return zebra_static_ipv4_safi(vty, SAFI_MULTICAST, 0, argv[0], NULL, argv[1],
                                 NULL, argc > 2 ? argv[2] : NULL);
 }
@@ -203,6 +205,8 @@ DEFUN (ip_multicast_mode,
        "Lookup both, use entry with lower distance\n"
        "Lookup both, use entry with longer prefix\n")
 {
+  VTY_WARN_EXPERIMENTAL();
+
   if (!strncmp (argv[0], "u", 1))
     multicast_mode_ipv4_set (MCAST_URIB_ONLY);
   else if (!strncmp (argv[0], "mrib-o", 6))
@@ -254,6 +258,7 @@ DEFUN (show_ip_rpf,
        IP_STR
        "Display RPF information for multicast source\n")
 {
+  VTY_WARN_EXPERIMENTAL();
   return do_show_ip_route(vty, SAFI_MULTICAST);
 }
 
@@ -270,6 +275,8 @@ DEFUN (show_ip_rpf_addr,
   struct rib *rib;
   int ret;
 
+  VTY_WARN_EXPERIMENTAL();
+
   ret = inet_aton (argv[0], &addr);
   if (ret == 0)
     {
-- 
2.0.4





More information about the Quagga-dev mailing list