[quagga-dev 12735] Re: [PATCH] realms support and small fix

Donald Sharp sharpd at cumulusnetworks.com
Mon Jun 15 17:58:01 BST 2015

Possibly need to break up the patch into smaller patches, starting with 
changes to lib, then zebra, then bgp.

Why does bgp display the realm id, not the the realm name?
Why is support for realms bgp only?  Shouldn't it just be part of the 
normal route-map code in lib/routemap.c?( I may be wrong here, I can 
safely say I don't fully understand the routemap code yet )
Is there any particular reason we reread /etc/iproute2/rt_realms file 
for every call into rtnl_rtrealm_a2n()?
The expected file format for /etc/iproute2/rt_realms is pretty limiting, 
is this intentional?( Who maintains this file?  By hand? )
I think I would prefer to just add the u_int16_t realmid to rib_add_ipv4 
function and ignore the realmid passed in if it's not used.  I'm not a 
big fan of functions with different #'s of parameters based upon 
configure options.  I would personally prefer the lower level function 
just do the 'right' thing if it's configured and do the right thing if 
it's not.

On 6/15/15 10:24 AM, Kaloyan Kovachev wrote:
> Hello devs,
> I am using the realms patch from Adrian Ban [1] for several years, but 
> it is still missing from Quagga, while it is very useful (not only for 
> me I hope).
> I have ported the patch for the latest version on GitHup and while 
> working on it found another small bug, which I have fixed [3]
> Is there something else that needs to be done so they can be included 
> in the official source?
> [1] http://linux.mantech.ro/quagga+realm_en.php
> [2] 
> https://github.com/KaloNK/quagga/commit/9e9a79c5d11863c271477262d2dc2e94b94fdcd2
> [3] 
> https://github.com/KaloNK/quagga/commit/1037020f7708c599ce9c9c8b2e36463e532aaa98
> _______________________________________________
> Quagga-dev mailing list
> Quagga-dev at lists.quagga.net
> https://lists.quagga.net/mailman/listinfo/quagga-dev

More information about the Quagga-dev mailing list