[quagga-dev 12095] [GIT RFC] "final" warning cleanup

David Lamparter equinox at opensourcerouting.org
Wed Mar 4 06:53:34 GMT 2015


Hi everyone,


I went and killed the remaining warnings that crop up when compiling
Quagga.  The result is pushed at:
http://git.savannah.gnu.org/cgit/quagga.git/log/?h=volatile/fix_warnings

The following patches are non-trivial and might need some additional
eyes:
 - "zebra: use SA_SIZE for RT_ROUNDUP on FreeBSD"
 - "bgpd: fix SNMP write support"

Additionally, the following patches fix things that may have been
problems:
 - "bgpd, zebra: fix struct/pointer sizeof mixups"
 - "isisd: fix minor & vs. && mix-up"

Everything else *should* be trivial.  Note the last 2 patches in the
branch change CFLAGS behavior and add "--enable-werror".  I intend to
start using the latter and insta-refuse any patches that introduce
warnings.

I have a warning-free build in the following environments:

Linux/glibc 2.20:
 - gcc 4.5.4, 4.6.4, 4.7.4, 4.8.3, 4.9.2
 - clang 3.5.0
 - icc 14.0.3

FreeBSD 10.0-RELEASE-p17
 - clang 3.3

(Greg, can you do a run on NetBSD?)


If you have comments, please post them now - even though this says RFC
in the subject, there might not be another list cycle on this :)

Cheers,


-David




More information about the Quagga-dev mailing list