[quagga-dev 12097] Re: [GIT RFC] "final" warning cleanup

Donald Sharp sharpd at cumulusnetworks.com
Wed Mar 4 13:23:02 GMT 2015


David -

This is good.  I've been working on cleaning up the warnings as well, this
will obviate a bunch of my changes.
I'm not sure of a great way to offer comments so if you want a different
methodology please let me know.  I only have a couple comments:

http://git.savannah.gnu.org/cgit/quagga.git/commit/?h=volatile/fix_warnings&id=8315f262ecf6a03def8ac28ffddbbd9086c23314

diff --git a/bgpd/bgp_ecommunity.c b/bgpd/bgp_ecommunity.c
index 482e76b..d258bdb 100644
--- a/bgpd/bgp_ecommunity.c
<http://git.savannah.gnu.org/cgit/quagga.git/tree/bgpd/bgp_ecommunity.c?h=volatile/fix_warnings&id=9fe74814bdd66fd563f1ce8a9a6b68b93486b6dc>
+++ b/bgpd/bgp_ecommunity.c
<http://git.savannah.gnu.org/cgit/quagga.git/tree/bgpd/bgp_ecommunity.c?h=volatile/fix_warnings&id=8315f262ecf6a03def8ac28ffddbbd9086c23314>
@@ -511,7 +511,7 @@ struct ecommunity *
ecommunity_str2com (const char *str, int type, int keyword_included)
{
struct ecommunity *ecom = NULL;
- enum ecommunity_token token;
+ enum ecommunity_token token = 0;
struct ecommunity_val eval;
int keyword = 0;
can we set token = ecommunity_token_unknown instead of 0?  I wouldn't mind
moving ecommunity_token_unknown to the front of the enum either.


http://git.savannah.gnu.org/cgit/quagga.git/commit/?h=volatile/fix_warnings&id=fc671a1d779ce65740689af7522e5b68e00a451e

Why not just remove the lines, instead of commenting them out, and why set
some variables to unused?  Just remove them as well?

donald


On Wed, Mar 4, 2015 at 1:53 AM, David Lamparter <
equinox at opensourcerouting.org> wrote:

> Hi everyone,
>
>
> I went and killed the remaining warnings that crop up when compiling
> Quagga.  The result is pushed at:
> http://git.savannah.gnu.org/cgit/quagga.git/log/?h=volatile/fix_warnings
>
> The following patches are non-trivial and might need some additional
> eyes:
>  - "zebra: use SA_SIZE for RT_ROUNDUP on FreeBSD"
>  - "bgpd: fix SNMP write support"
>
> Additionally, the following patches fix things that may have been
> problems:
>  - "bgpd, zebra: fix struct/pointer sizeof mixups"
>  - "isisd: fix minor & vs. && mix-up"
>
> Everything else *should* be trivial.  Note the last 2 patches in the
> branch change CFLAGS behavior and add "--enable-werror".  I intend to
> start using the latter and insta-refuse any patches that introduce
> warnings.
>
> I have a warning-free build in the following environments:
>
> Linux/glibc 2.20:
>  - gcc 4.5.4, 4.6.4, 4.7.4, 4.8.3, 4.9.2
>  - clang 3.5.0
>  - icc 14.0.3
>
> FreeBSD 10.0-RELEASE-p17
>  - clang 3.3
>
> (Greg, can you do a run on NetBSD?)
>
>
> If you have comments, please post them now - even though this says RFC
> in the subject, there might not be another list cycle on this :)
>
> Cheers,
>
>
> -David
>
> _______________________________________________
> Quagga-dev mailing list
> Quagga-dev at lists.quagga.net
> https://lists.quagga.net/mailman/listinfo/quagga-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.quagga.net/pipermail/quagga-dev/attachments/20150304/a0a4dcc2/attachment-0001.html>


More information about the Quagga-dev mailing list