[quagga-dev 16468] Re: Submitting patch

Devaraj Gowda devaraj411mgowda at gmail.com
Fri Dec 9 21:20:29 GMT 2016


demt at bgl-ads-2457]/nobackup/demt/quagaa/ospfd>git diff -u ospf_ia.c
diff --git a/ospfd/ospf_ia.c b/ospfd/ospf_ia.c
index b2d0fae..331e4bc 100644
--- a/ospfd/ospf_ia.c
+++ b/ospfd/ospf_ia.c
@@ -250,6 +250,9 @@ process_summary_lsa (struct ospf_area *area,
struct route_table *rt,
       p.prefixlen == 0)
     return 0; /* Ignore summary default from a stub area */

+  if (!OSPF_IS_AREA_BACKBONE(area))
+    return 0; /* Ignore summary lsa in non_backbone_area */
+
   abr.family = AF_INET;
   abr.prefix = sl->header.adv_router;
   abr.prefixlen = IPV4_MAX_BITLEN;

On Fri, Dec 9, 2016 at 10:45 PM, Devaraj Gowda
<devaraj411mgowda at gmail.com> wrote:
> Hi all,
>
> I was thinking of making following changes while processing summary lsa in ospf.
>
> [demt at bgl-ads-2457]/nobackup/demt/quagaa/ospfd>git diff -u ospf_ia.c
> diff --git a/ospfd/ospf_ia.c b/ospfd/ospf_ia.c
> index b2d0fae..4121c18 100644
> --- a/ospfd/ospf_ia.c
> +++ b/ospfd/ospf_ia.c
> @@ -250,6 +250,11 @@ process_summary_lsa (struct ospf_area *area,
> struct route_table *rt,
>        p.prefixlen == 0)
>      return 0; /* Ignore summary default from a stub area */
>
> +  /* Ignore summary lsa in non_backbone_area */
> +  if (!OSPF_IS_AREA_BACKBONE(A))
> +    return 0;
> +
> +
>
> I think we should not process summary lsa's in non_backbone area. As
> this may create unnecessary loops.
> I'm new to this, please point me to next steps. if you think diff is needed.
>
> --
> Devarajegowda,
> Software Engineer
> Cisco Systems
> Bangalore



-- 
Devarajegowda,
Software Engineer
Cisco Systems
Bangalore




More information about the Quagga-dev mailing list