[quagga-dev 15655] Re: [PATCH 10/10] bgpd: add L3/L2VPN Virtual Network Control feature

Philippe Guibert philippe.guibert at 6wind.com
Mon Jun 20 07:30:40 BST 2016


On Fri, Jun 17, 2016 at 4:10 PM, Lou Berger <lberger at labn.net> wrote:

Hello Lou,


>> #if ENABLE_BGP_VNC
>> if (v != RD_TYPE_VNC_ETH)
>>    v |= (u_int16_t) *pnt;
>> #else
>> v |= (u_int16_t) *pnt;
>> #endif
>>
>> IMHO, I think this brings more clarity about the algorithm in place.
> I considered this, but I hate duplicate code so came down on the other
> side.  But I was on the fence, so will make this change.
>
If i can bring an argument between the two writings.
The clarity is brought by the extra spaces located just before v|=.
That indentation makes the code rewiew  clearer.

Regards,

Philippe




More information about the Quagga-dev mailing list